Always perform a require prior to analyzing a ns
#321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vemv
commented
Jul 9, 2021
| [refactor-nrepl.analyzer :as sut] | ||
| [clojure.test :refer [deftest is]])) | ||
|
|
||
| (deftest ns-ast-test |
There was a problem hiding this comment.
I verified that if we comment out this PR's main change, this test would fail, complaining about go-loop
expez
approved these changes
Jul 9, 2021
src/refactor_nrepl/analyzer.clj
Outdated
| @@ -77,7 +77,8 @@ | |||
| (not (util/self-referential? ns))) | |||
| ;; Use `locking`, because AST analysis can perform arbitrary evaluation. | |||
| ;; Parallel analysis is not safe, especially as it can perform `require` calls. | |||
| (locking core/require-lock | |||
| (locking core/require-lock ;; for both `require` and `aj/analyze-ns` | |||
| (require ns) ;; ease the work for t.ana | |||
There was a problem hiding this comment.
Here's a general tip with regards to writing comments: have them answer why questions.
Since it's here we can assume that it's needed, but we're still left asking why that is. You could remedy that with a comment like: ;; t.ana sometimes fails to require the needed namespaces on its own
There was a problem hiding this comment.
I'd use this as the comment here:
Performing this require makes it more likely that t.ana will succeed. I believe it's becase require will also require other stuff recursively. t.ana does so in theory as well but it's a bit more rigid.
|
Thanks for the suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #245
Performing this
requiremakes it more likely that t.ana will succeed. I believe it's becaserequirewill alsorequireother stuff recursively. t.ana does so in theory as well but it's a bit more rigid.